Skip to content

feat(core): Update all references to use new auth class using flare identity server for Amazon Q #7088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 21, 2025
Merged

feat(core): Update all references to use new auth class using flare identity server for Amazon Q #7088

merged 16 commits into from
Apr 21, 2025

Conversation

@opieter-aws
Copy link
Contributor

@opieter-aws opieter-aws commented Apr 17, 2025 •
edited
Loading

Problem

The business logic of auth-related features is complex and implemented separately for all IDEs. Flare/DEXP LSP server has implemented auth that can be reused for all IDEs. The source code was introduced already introduced in #6958 with activation and client updates in #7062. But the references to AuthUtil through the codebase weren't updated yet.

Solution

  • Update all remaining references to AuthUtil in the codebase
  • All toolkits unit tests are passing
  • Disable telemetry and existing AuthUtil unit tests, to be updated in follow-up PR
  • amazonq and web unit tests still failing, to be addressed in follow-up PR

Note that CI is expected to fail for amazonq and web unit tests

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@opieter-aws opieter-aws changed the title Feature/amazonq lsp auth feat(core): Update all references to use new auth class using flare identity server for Amazon Q Apr 17, 2025
@github-actions
Copy link

github-actions bot commented Apr 17, 2025

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@opieter-aws opieter-aws mentioned this pull request Apr 21, 2025
Closed
@opieter-aws opieter-aws marked this pull request as ready for review April 21, 2025 15:27
@opieter-aws opieter-aws requested review from a team as code owners April 21, 2025 15:27
hayemaxi
hayemaxi reviewed Apr 21, 2025
View reviewed changes
@opieter-aws opieter-aws merged commit e08eb59 into aws:feature/amazonqLSP-auth Apr 21, 2025
11 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hayemaxi hayemaxi hayemaxi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@opieter-aws @hayemaxi